| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
| Cc: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Cleaning up and speeding up string functions |
| Date: | 2019-07-22 15:41:05 |
| Message-ID: | 20190722154105.GA23667@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-Jul-22, Dagfinn Ilmari Mannsåker wrote:
> ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker) writes:
>
> > I noticed a lot of these are appending one StringInfo onto another;
> > would it make sense to introduce a helper funciton
> > appendStringInfoStringInfo(StringInfo str, StringInfo str2) to avoid the
> > `str.data, str2.len` repetition?
>
> A bit of grepping only turned up 18 uses, but I was bored and whipped up
> the attached anyway, in case we decide it's worth it.
David had already submitted the same thing upthread, and it was rejected
on the grounds that it increases the code space.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-07-22 15:57:13 | Re: Add parallelism and glibc dependent only options to reindexdb |
| Previous Message | Dagfinn Ilmari Mannsåker | 2019-07-22 15:37:18 | Re: Cleaning up and speeding up string functions |