Re: REINDEX CONCURRENTLY 2.0

From: ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker )
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Sergei Kornilov <sk(at)zsrv(dot)org>, "pgsql-hackers\(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: REINDEX CONCURRENTLY 2.0
Date: 2019-04-12 11:11:12
Message-ID: d8jbm1b32cv.fsf@dalvik.ping.uio.no
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:

> So... I am coming up with the patch attached. I have introduced some
> tests using a trick with CIC to have an invalid index to work on.

I don't have any comments on the code (but the test looks sensible, it's
the same trick I used to discover the issue in the first place).

However, the doc patch lost the trailing paren:

> The recommended recovery
> method in such cases is to drop the index and try again to perform
> - <command>CREATE INDEX CONCURRENTLY</command>. (Another possibility is to rebuild
> - the index with <command>REINDEX</command>. However, since <command>REINDEX</command>
> - does not support concurrent builds, this option is unlikely to seem
> - attractive.)
> + <command>CREATE INDEX CONCURRENTLY</command>. (Another possibility is
> + to rebuild the index with <command>REINDEX INDEX CONCURRENTLY</command>.
> </para>

- ilmari
--
- Twitter seems more influential [than blogs] in the 'gets reported in
the mainstream press' sense at least. - Matt McLeod
- That'd be because the content of a tweet is easier to condense down
to a mainstream media article. - Calle Dybedahl

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-04-12 12:07:07 Re: Calling pgstat_report_wait_end() before ereport(ERROR)
Previous Message Masahiko Sawada 2019-04-12 10:27:44 Calling pgstat_report_wait_end() before ereport(ERROR)