Re: pgsql: pg_verifybackup: Enable WAL parsing for tar-format backups

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: pg_verifybackup: Enable WAL parsing for tar-format backups
Date: 2026-05-04 09:30:48
Message-ID: d82e0127-8f18-4231-98df-cae0e6cd4ad2@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 20.03.26 20:32, Andrew Dunstan wrote:
> pg_verifybackup: Enable WAL parsing for tar-format backups
>
> Now that pg_waldump supports reading WAL from tar archives, remove the
> restriction that forced --no-parse-wal for tar-format backups.
>
> pg_verifybackup now automatically locates the WAL archive: it looks for
> a separate pg_wal.tar first, then falls back to the main base.tar. A
> new --wal-path option (replacing the old --wal-directory, which is kept
> as a silent alias) accepts either a directory or a tar archive path.

In the past, we have opted against silent aliases when changing a
command-line option. All options should be documented, even if they are
deprecated. Otherwise, it's confusing for users moving between major
versions or those who find that undocumented options happen to work.
See commit 35ce24c333c for an example how this was done in the past.

I suggest the option --wal-directory should be added back to the
documentation and help output.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2026-05-04 09:58:09 pgsql: Add missing serial commas
Previous Message Peter Eisentraut 2026-05-04 09:23:04 pgsql: doc: Fix up spacing around verbatim DocBook elements