| From: | Amul Sul <sulamul(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: pg_verifybackup: Enable WAL parsing for tar-format backups |
| Date: | 2026-05-04 11:16:24 |
| Message-ID: | CAAJ_b95pj6rq4yw09Ds-7x8-HLHFbseJEXag5TDPb_CZewBgRA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Mon, May 4, 2026 at 3:00 PM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
> On 20.03.26 20:32, Andrew Dunstan wrote:
> > pg_verifybackup: Enable WAL parsing for tar-format backups
> >
> > Now that pg_waldump supports reading WAL from tar archives, remove the
> > restriction that forced --no-parse-wal for tar-format backups.
> >
> > pg_verifybackup now automatically locates the WAL archive: it looks for
> > a separate pg_wal.tar first, then falls back to the main base.tar. A
> > new --wal-path option (replacing the old --wal-directory, which is kept
> > as a silent alias) accepts either a directory or a tar archive path.
>
> In the past, we have opted against silent aliases when changing a
> command-line option. All options should be documented, even if they are
> deprecated. Otherwise, it's confusing for users moving between major
> versions or those who find that undocumented options happen to work.
> See commit 35ce24c333c for an example how this was done in the past.
>
> I suggest the option --wal-directory should be added back to the
> documentation and help output.
Agreed. Attached is a quick fix.
Regards,
Amul
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Document-deprecated-wal-directory-option-for-pg_veri.patch | application/octet-stream | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2026-05-04 13:51:58 | pgsql: Do not define type for a property graph |
| Previous Message | Peter Eisentraut | 2026-05-04 10:06:28 | pgsql: Fix options listing of pg_restore --no-globals |