| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Oddity in handling of cached plans for FDW queries |
| Date: | 2016-07-22 03:41:06 |
| Message-ID: | d674a3f1-6b63-519c-ef3f-f3188ed6a178@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2016/07/21 16:30, Etsuro Fujita wrote:
> One thing I'd like to discuss is GetUserMappingById/GetUserMappingId.
> Though those functions aren't used in any places, I didn't take them
> out, because I thought somebody else would need them someday. But
> considering that user mapping OIDs now aren't available in RelOptInfos,
> at least the former might be rather useless. Should we keep them in core?
I thought a bit more about this. ISTM that there isn't much value in
the latter either, because we can use GetUserMapping and get that OID
from the result, instead of using the latter, so I'd vote for removing
those functions. Attached is a patch for that.
Best regards,
Etsuro Fujita
| Attachment | Content-Type | Size |
|---|---|---|
| remove-usermapping-helper-funcs.patch | binary/octet-stream | 5.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2016-07-22 05:09:26 | Re: Visual Studio 2015 and telemetry calls |
| Previous Message | Michael Paquier | 2016-07-22 02:50:52 | Re: Visual Studio 2015 and telemetry calls |