| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Oddity in handling of cached plans for FDW queries |
| Date: | 2016-07-22 15:33:03 |
| Message-ID: | 29861.1469201583@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> writes:
> On 2016/07/21 16:30, Etsuro Fujita wrote:
>> One thing I'd like to discuss is GetUserMappingById/GetUserMappingId.
>> Though those functions aren't used in any places, I didn't take them
>> out, because I thought somebody else would need them someday. But
>> considering that user mapping OIDs now aren't available in RelOptInfos,
>> at least the former might be rather useless. Should we keep them in core?
> I thought a bit more about this. ISTM that there isn't much value in
> the latter either, because we can use GetUserMapping and get that OID
> from the result, instead of using the latter, so I'd vote for removing
> those functions. Attached is a patch for that.
Agreed - pushed.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Nasby | 2016-07-22 17:50:30 | Bug with plpgsql handling of NULL argument of compound type |
| Previous Message | Craig Ringer | 2016-07-22 15:20:07 | Re: Design for In-Core Logical Replication |