Re: pg_dump --with-* options

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump --with-* options
Date: 2025-07-10 17:57:14
Message-ID: d64d902780ab6f95ea30093b4985d097d7b29605.camel@j-davis.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 2025-06-25 at 08:18 +0900, Fujii Masao wrote:
> For pg_dump and pg_dumpall, I agree with Jeff's idea in [1],
> but if the statistics is skipped by default, I don't think
> we need a --no-statistics option. So, here's how I think
> the options should work:
>
>      * Keep: --schema-only, --data-only, --statistics-only, --no-
> schema, --no-data, -and -statistics
>      * Remove: --no-statistics, --with-schema, and --with-data

...

> For pg_restore, I believe there's agreement to restore statistics
> by default if they exist in the archive. So:
>
>      * Keep: --schema-only, --data-only, --statistics-only, --no-
> schema, --no-data, and --no-statistics
>      * Remove: --with-schema, --with-data, and --statistics

That means pg_dump will accept --statistics and reject --no-statistics;
and pg_restore will accept --no-statistics and reject --statistics.
Other options are mostly the same between them, so I'm not sure it's a
good idea for them to diverge.

Regards,
Jeff Davis

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2025-07-10 18:08:01 Re: C11 / VS 2019
Previous Message Jeff Davis 2025-07-10 17:42:26 Re: pg_dump --with-* options