| From: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Jeff Davis <pgsql(at)j-davis(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, fabriziomello(at)gmail(dot)com, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Rahila Syed <rahila(dot)syed(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Minimal logical decoding on standbys |
| Date: | 2023-04-07 04:58:21 |
| Message-ID: | d61e5717-b318-d205-5a15-3406a23d104c@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 4/7/23 3:59 AM, Amit Kapila wrote:
> On Fri, Apr 7, 2023 at 6:55 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
>>
>> On 2023-04-06 12:10:57 +0530, Amit Kapila wrote:
>>> After this, I think for backends that have active slots, it would
>>> simply cancel the current query. Will that be sufficient? Because we
>>> want the backend process should exit and release the slot so that the
>>> startup process can mark it invalid.
>>
>> We don't need them to exit, we just need them to release the slot. Which does
>> happen when the query is cancelled. Imagine if that weren't the case - if a
>> cancellation of pg_logical_slot_* wouldn't release the slot, we couldn't call
>> it again before disconnecting. I also did verify that indeed the slot is
>> released upon a cancellation.
>>
>
> makes sense. Thanks for the clarification!
>
+1, thanks Andres!
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Drouvot, Bertrand | 2023-04-07 05:00:27 | Re: Minimal logical decoding on standbys |
| Previous Message | Amit Kapila | 2023-04-07 03:47:33 | Re: Minimal logical decoding on standbys |