|From:||Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>|
|To:||Michael Banck <michael(dot)banck(at)credativ(dot)de>, Magnus Hagander <magnus(at)hagander(dot)net>|
|Cc:||Pg Hackers <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: Create replication slot in pg_basebackup if requested and not yet present|
|Views:||Raw Message | Whole Thread | Download mbox|
On 19.03.2017 21:45, Michael Banck wrote:
> So the patch I sent earlier creates the slot in ReceiveXlogStream() in
> receivewal.c, as that's where the temp slot gets created as well, but
> now I wonder whether that is maybe not the best place, as pg_receivewal
> also calls that function. The other problem with receivewal.c is that
> `verbose' isn't around in it so I don't how I'd print out a message
> So probably it is better to create the slot in pg_basebackup.c's
> StartLogStreamer(), see the attached first patch, that one also adds
> a verbose message.
I think such too. I suppose it is more clearly. StartLogStreamer() is
better place for creating permanent and temporary slots.
Also maybe it would be good if pg_basebackup had a way to drop created
slot. Although "drop slot" is not related with concept of automatically
created slots, it will good if user will have a way to drop slots.
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
|Next Message||Amit Kapila||2017-03-20 11:47:41||Re: [POC] A better way to expand hash indexes.|
|Previous Message||Alexander Korotkov||2017-03-20 11:24:45||Re: PinBuffer() no longer makes use of strategy|