| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Christoph Berg <myon(at)debian(dot)org> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: PGCOLOR? (Re: pgsql: Unified logging system for command-line programs) |
| Date: | 2019-04-09 10:55:22 |
| Message-ID: | d483cdb6-db98-9b2f-7f2b-eed0f4bd975d@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2019-04-09 11:22, Christoph Berg wrote:
> Can we rename PG_COLOR to PGCOLOR? This is the only PG* environment
> variable prefixed with the extra underscore, and remembering that will
> be confusing. (Like pgbench should really be named pg_bench for
> consistency.) Even if it's not a libpq variable, but that's an
> implementation detail that users shouldn't have to worry about.
I'm okay with changing it. As you indicate, I chose the name so that it
doesn't look like a libpq variable. There are some other PG_ variables
throughout the code, but those appear to be mostly for internal use.
Also, there is GCC_COLORS, LS_COLORS, etc. But perhaps this wisdom will
be lost on users who just read the man page and get confused. ;-)
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christoph Berg | 2019-04-09 11:58:14 | Re: pgsql: Unified logging system for command-line programs |
| Previous Message | Christoph Berg | 2019-04-09 09:22:21 | PGCOLOR? (Re: pgsql: Unified logging system for command-line programs) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ibrar Ahmed | 2019-04-09 11:52:02 | Re: dropdb --force |
| Previous Message | Ibrar Ahmed | 2019-04-09 10:41:00 | Re: dropdb --force |