| From: | Christoph Berg <myon(at)debian(dot)org> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: PGCOLOR? (Re: pgsql: Unified logging system for command-line programs) |
| Date: | 2019-04-09 12:01:12 |
| Message-ID: | 20190409120112.GC1961@msg.df7cb.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Re: Peter Eisentraut 2019-04-09 <d483cdb6-db98-9b2f-7f2b-eed0f4bd975d(at)2ndquadrant(dot)com>
> I'm okay with changing it. As you indicate, I chose the name so that it
> doesn't look like a libpq variable. There are some other PG_ variables
> throughout the code, but those appear to be mostly for internal use.
> Also, there is GCC_COLORS, LS_COLORS, etc. But perhaps this wisdom will
> be lost on users who just read the man page and get confused. ;-)
Do we need two variables to control this? I was only looking at
PG_COLOR, and noticed PG_COLORS only later. Keeping PG_COLORS aligned
with {GCC,LS}_COLORS makes sense. How about removing PG_COLOR, and
making "auto" the default? (Maybe we could still support "PG_COLORS=off")
Christoph
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2019-04-09 13:59:42 | pgsql: Replace tabs with spaces in one .sql file |
| Previous Message | Christoph Berg | 2019-04-09 11:58:14 | Re: pgsql: Unified logging system for command-line programs |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-04-09 12:32:20 | Re: Status of the table access method work |
| Previous Message | Christoph Berg | 2019-04-09 11:58:14 | Re: pgsql: Unified logging system for command-line programs |