| From: | Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com> |
|---|---|
| To: | "Seki, Eiji" <seki(dot)eiji(at)jp(dot)fujitsu(dot)com>, 'Michael Paquier' <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Proposal: GetOldestXminExtend for ignoring arbitrary vacuum flags |
| Date: | 2017-02-14 18:38:04 |
| Message-ID: | d1f28eb6-f8b5-387e-39e5-1cc3e3092974@BlueTreble.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2/14/17 3:13 AM, Seki, Eiji wrote:
> +extern TransactionId GetOldestXmin(Relation rel, uint8 ignoreFlags);
My impression is that most other places that do this sort of thing just
call the argument 'flags', so as not to "lock in" a single idea of what
the flags are for. I can't readily think of another use for flags in
GetOldestXmin, but ISTM it's better to just go with "flags" instead of
"ignoreFlags".
--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com
855-TREBLE2 (855-873-2532)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-02-14 18:41:33 | Re: gitlab post-mortem: pg_basebackup waiting for checkpoint |
| Previous Message | Jim Nasby | 2017-02-14 18:33:35 | Re: possibility to specify template database for pg_regress |