| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: SSL test names |
| Date: | 2018-02-08 16:18:19 |
| Message-ID: | d1e2697f-bd47-6292-b096-a48eb7e5b6a5@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2/7/18 23:18, Michael Paquier wrote:
> You need to update the comment on top of test_connect_ok in
> ServerSetup.pm.
done and committed
> Wouldn't it be better to use the expected result
> as an argument and merge test_connect_ok and test_connect_fails?
That doesn't seem to be the general style, and I think it's more
readable the way it is now.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2018-02-08 17:04:44 | Re: New gist vacuum. |
| Previous Message | Markus Nullmeier | 2018-02-08 16:17:07 | Re: [HACKERS] Proposal: generic WAL compression |