Re: v12 pg_basebackup fails against older servers (take two)

From: Devrim Gündüz <devrim(at)gunduz(dot)org>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: v12 pg_basebackup fails against older servers (take two)
Date: 2019-10-22 10:37:18
Message-ID: d1c507731779254bb53c93e50e02432c3236e94f.camel@gunduz.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hi,

On Tue, 2019-10-22 at 19:16 +0900, Michael Paquier wrote:
> You are referring to the connection string generated in
> primary_conninfo here, right?

Right.

> It would be nice to be more compatible here. This can be simply fixed by
> having an extra filter in GenerateRecoveryConfig() (different file between
> HEAD and REL_12_STABLE). I also think that there is more. On HEAD,
> channel_binding gets added to the connection string generated which
> would equally cause a failure with pg_basebackup from HEAD used for a
> v12 or older server.

https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=beeb8e2e0717065296dc7b32daba2d66f0f931dd

had a similar approach in backwards compatibility, so I also agree on fixing
whatever breaks it.

Regards,
--
Devrim Gündüz
Open Source Solution Architect, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2019-10-22 10:43:03 Re: Proposal: Make use of C99 designated initialisers for nulls/values arrays
Previous Message Michael Paquier 2019-10-22 10:16:33 Re: v12 pg_basebackup fails against older servers (take two)