Re: v12 pg_basebackup fails against older servers (take two)

Greetings,

* Devrim Gündüz (devrim(at)gunduz(dot)org) wrote:
> On Tue, 2019-10-22 at 19:16 +0900, Michael Paquier wrote:
> > You are referring to the connection string generated in
> > primary_conninfo here, right?
>
> Right.

I'm awful suspicious that there's other similar cases beyond this
particular one...

> > It would be nice to be more compatible here. This can be simply fixed by
> > having an extra filter in GenerateRecoveryConfig() (different file between
> > HEAD and REL_12_STABLE). I also think that there is more. On HEAD,
> > channel_binding gets added to the connection string generated which
> > would equally cause a failure with pg_basebackup from HEAD used for a
> > v12 or older server.
>
> https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=beeb8e2e0717065296dc7b32daba2d66f0f931dd
>
> had a similar approach in backwards compatibility, so I also agree on fixing
> whatever breaks it.

Yeah, we clearly do want newer versions of pg_basebackup to work with
older versions of PG and therefore we should address this.

Here's just a quick rough-up of a patch (it compiles, I haven't tried it
out more than that) that adds in a check to skip gssencmode on older
versions. If it seems like a reasonable approach then I can test it out
and deal with back-patching it and such.

Thoughts?

Thanks,

Stephen