Re: Non-text mode for pg_dumpall

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: jian he <jian(dot)universality(at)gmail(dot)com>, Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Vaibhav Dalvi <vaibhav(dot)dalvi(at)enterprisedb(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Non-text mode for pg_dumpall
Date: 2026-06-15 20:11:16
Message-ID: cfc6ae07-a161-4ada-bf8c-57eed960e5ff@dunslane.net
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2026-06-06 Sa 8:02 PM, Noah Misch wrote:
> On Thu, Feb 26, 2026 at 09:02:48AM -0500, Andrew Dunstan wrote:
>> pushed with a slight tweak.
> Having now reviewed commit 763aaa0, I don't think it's ready to remain part of
> v19. While some points from my v18 review are now resolved, other points
> still seem unresolved. I didn't find discussion of the unresolved points. I
> also see new issues.

OK, here's a reversion path. It's a bit messy, and I didn't touch the
release notes, but apart from that I think it does the right thing.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Attachment Content-Type Size
0001-Revert-non-text-pg_dumpall.patch text/x-patch 127.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Sami Imseih 2026-06-15 20:26:59 Re: mxid_score can become Infinity in pg_stat_autovacuum_scores
Previous Message Tom Lane 2026-06-15 19:47:42 Re: [oauth] Increased CPU usage during device flow with libcurl 8.20.0