| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, vignesh C <vignesh21(at)gmail(dot)com>, Shinya11(dot)Kato(at)nttdata(dot)com, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: psql - factor out echo code |
| Date: | 2022-11-30 09:24:20 |
| Message-ID: | cf982bbd-b6d4-8855-cef-78e1adb77374@mines-paristech.fr |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Hmm. The refactoring is worth it as much as the differentiation
> between QUERY and INTERNAL QUERY as the same pattern is repeated 5
> times.
>
> Now some of the output generated by test_extdepend gets a bit
> confusing:
> +-- QUERY:
> +
> +
> +-- QUERY:
>
> That's not entirely this patch's fault. Still that's not really
> intuitive to see the output of a query that's just a blank spot..
Hmmm.
What about adding an explicit \echo before these empty outputs to mitigate
the possible induced confusion?
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2022-11-30 09:43:09 | Re: psql - factor out echo code |
| Previous Message | Jelte Fennema | 2022-11-30 09:20:42 | Re: [EXTERNAL] Re: Add non-blocking version of PQcancel |