Re: psql - factor out echo code

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, vignesh C <vignesh21(at)gmail(dot)com>, Shinya11(dot)Kato(at)nttdata(dot)com, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: psql - factor out echo code
Date: 2022-11-30 09:43:09
Message-ID: cb73a3f-52c2-b51-e020-4c5cca2ce2d1@minesparis.psl.eu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


>> Now some of the output generated by test_extdepend gets a bit
>> confusing:
>> +-- QUERY:
>> +
>> +
>> +-- QUERY:
>>
>> That's not entirely this patch's fault. Still that's not really
>> intuitive to see the output of a query that's just a blank spot..
>
> Hmmm.
>
> What about adding an explicit \echo before these empty outputs to mitigate
> the possible induced confusion?

\echo is not possible.

Attached an attempt to improve the situation by replacing empty lines with
comments in this test.

--
Fabien.

Attachment Content-Type Size
psql-echo-6.patch text/x-diff 11.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii.Yuki@df.MitsubishiElectric.co.jp 2022-11-30 10:01:41 RE: Partial aggregates pushdown
Previous Message Fabien COELHO 2022-11-30 09:24:20 Re: psql - factor out echo code