Re: SSL Tests for sslinfo extension

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: SSL Tests for sslinfo extension
Date: 2021-05-19 19:05:29
Message-ID: cef59c00-8136-157f-5401-2add87c6e014@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 5/19/21 1:01 PM, Dagfinn Ilmari Mannsåker wrote:
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>
>> In order to be able to test extensions with SSL connections, allow
>> configure_test_server_for_ssl to create any extensions passed as
>> comma separated list. Each extension is created in all the test
>> databases which may or may not be useful.
> Why the comma-separated string, rather than an array reference,
> i.e. `extensions => [qw(foo bar baz)]`? Also, should it use `CREATE
> EXTENSION .. CASCADE`, in case the specified extensions depend on
> others?
>

Also, instead of one line per db there should be an inner loop over the
db  names.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2021-05-19 19:07:21 Re: Commitfest app vs. pgsql-docs
Previous Message Andrew Dunstan 2021-05-19 18:54:27 Re: Commitfest app vs. pgsql-docs