Re: [Refactor]Avoid to handle FORCE_NOT_NULL/FORCE_NULL options when COPY TO

From: Zhang Mingli <zmlpostgres(at)gmail(dot)com>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: guofenglinux(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [Refactor]Avoid to handle FORCE_NOT_NULL/FORCE_NULL options when COPY TO
Date: 2022-08-02 08:13:30
Message-ID: cdf7a67c-3f5e-4ce7-86db-151f86e27d8a@Spark
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Zhang Mingli
On Aug 2, 2022, 12:30 +0800, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, wrote:
> An empty List is not NULL but NIL (which values are identical,
> though).
Thanks for pointing that out. Fix it in new patch.
> There are some other option combinations that are rejected
> by ProcessCopyOptions. On the other hand *re*checking all
> combinations that the function should have rejected is kind of silly.
> Addition to that, I doubt the assertions are really needed even though
> the wrong values don't lead to any serious consequence.
ProcessCopyOptions has rejected all invalid combinations and assertions are optional.
> regards.
> --
> Kyotaro Horiguchi
> NTT Open Source Software Center

Attachment Content-Type Size
vn-0004-Avoid-to-handle-FORCE_NOT_NULL-FORCE_NULL-options.patch application/octet-stream 3.5 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2022-08-02 08:17:35 Re: COPY TO (FREEZE)?
Previous Message Japin Li 2022-08-02 07:58:40 Re: Typo in pg_db_role_setting.h