Re: [Refactor]Avoid to handle FORCE_NOT_NULL/FORCE_NULL options when COPY TO

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: zmlpostgres(at)gmail(dot)com
Cc: guofenglinux(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [Refactor]Avoid to handle FORCE_NOT_NULL/FORCE_NULL options when COPY TO
Date: 2022-08-02 04:30:50
Message-ID: 20220802.133050.1983300389899830471.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Mon, 1 Aug 2022 09:59:49 +0800, Zhang Mingli <zmlpostgres(at)gmail(dot)com> wrote in
> On Jul 29, 2022, 11:24 +0800, Richard Guo <guofenglinux(at)gmail(dot)com>, wrote:
> >
> > > On Thu, Jul 28, 2022 at 9:04 PM Zhang Mingli <zmlpostgres(at)gmail(dot)com> wrote:
> > > > Assertions added.
> > >
> > > Can we also add assertions to make sure force_quote, force_notnull and
> > > force_null are available only in CSV mode?
>
> More assertions added.

An empty List is not NULL but NIL (which values are identical,
though). There are some other option combinations that are rejected
by ProcessCopyOptions. On the other hand *re*checking all
combinations that the function should have rejected is kind of silly.
Addition to that, I doubt the assertions are really needed even though
the wrong values don't lead to any serious consequence.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Japin Li 2022-08-02 04:34:29 Re: Typo in pg_db_role_setting.h
Previous Message Kyotaro Horiguchi 2022-08-02 04:30:46 COPY TO (FREEZE)?