| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Richard Guo <guofenglinux(at)gmail(dot)com>, John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Typo in pg_db_role_setting.h |
| Date: | 2022-08-02 07:58:40 |
| Message-ID: | MEYP282MB1669B6F3DBAA06826CC4B52AB69D9@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 02 Aug 2022 at 15:45, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> On 2 Aug 2022, at 09:37, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
>
>> The examples listed upthread all contain such comment in foo.h saying
>> 'prototypes for functions in foo.c'. For instance, in buffile.h, there is
>> comment saying
>
>> /*
>> * prototypes for functions in buffile.c
>> */
>>
>> So if we remove such comments, should we also do so for those cases?
>
> Comments which state the obvious are seldom helpful, I would prefer to remove
> such comments and only explicitly call out the .c file in a comment when it's a
> different basename from the header.
+1
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhang Mingli | 2022-08-02 08:13:30 | Re: [Refactor]Avoid to handle FORCE_NOT_NULL/FORCE_NULL options when COPY TO |
| Previous Message | Daniel Gustafsson | 2022-08-02 07:45:36 | Re: Typo in pg_db_role_setting.h |