Re: run pgindent on a regular basis / scripted manner

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Jelte Fennema <postgres(at)jeltef(dot)nl>
Cc: "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Noah Misch <noah(at)leadboat(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Bruce Momjian <bruce(at)momjian(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Jesse Zhang <sbjesse(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: run pgindent on a regular basis / scripted manner
Date: 2023-02-14 16:46:24
Message-ID: ccc8f27d-9b67-155e-fe31-9eb79761d7a5@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2023-02-13 Mo 13:29, Jelte Fennema wrote:
> On Mon, 13 Feb 2023 at 17:47, Andrew Dunstan<andrew(at)dunslane(dot)net> wrote:
>> OK, but I'd like to hear from more people about what they want. Experience tells me that making assumptions about how people work is not a good idea. I doubt anyone's work pattern is like mine. I don't want to implement an option that three people are going to use.
>
> In the general case I agree with you. But in this specific case I
> don't. To me the whole point of this email thread is to nudge people
> towards indenting the changes that they are committing. Thus indenting
> those changes (either before or after adding) is the workflow that we
> want to make as easy as possible. Because even if it's not people
> their current workflow, by adding the flag it hopefully becomes their
> workflow, because it's so easy to use. So my point is we want to
> remove as few hurdles as possible for people to indent their changes
> (and setting up git aliases or pre-commit hooks are all hurdles).

(ITYM "remove as many hurdles as possible"). It remains to be seen how
much easier any of this will make life for committers, at least. But I
concede this might make life a bit simpler for developers generally.

Anyway, let's talk about the details of what is proposed.

So far, we have had the following categories suggested: dirty, staged,
dirty+staged, untracked. Are there any others?

Another issue is whether or not to restrict these to files under the
current directory. I think we probably should, or at least provide a
--relative option.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Laurenz Albe 2023-02-14 16:53:33 Re: Allow tailoring of ICU locales with custom rules
Previous Message Anton A. Melnikov 2023-02-14 15:52:20 Re: odd buildfarm failure - "pg_ctl: control file appears to be corrupt"