Re: IPC/MultixactCreation on the Standby server

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Dmitry Yurichev <dsy(dot)075(at)yandex(dot)ru>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Cc: Álvaro Herrera <alvherre(at)kurilemu(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Ivan Bykov <i(dot)bykov(at)modernsys(dot)ru>, Kirill Reshke <reshkekirill(at)gmail(dot)com>
Subject: Re: IPC/MultixactCreation on the Standby server
Date: 2025-12-03 17:19:53
Message-ID: cbe00f76-f3d1-4b3b-abd7-eabbff7b3c05@iki.fi
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 03/12/2025 16:19, Dmitry Yurichev wrote:
> On 12/2/25 16:48, Heikki Linnakangas wrote:
>> Thanks! Agreed, v14-16 were the same. v17 and v18 might be worth
>> testing separately, to make sure I didn't e.g. screw up the locking
>> differences.
>
> I tested on the REL_18_1 tag (with applying v15-pg18-0001-Set-next-
> multixid-s-offset-when-creating-a-.patch).
> I didn't notice any deadlocks or other errors. Thanks!

Okay. I fixed a few more little things:

- fixed the warnings about shadowed variables that Andrey pointed out
- in older branches before we switched to 64-bit SLRU page numbers, use
'int' rather than 'int64' in page number variables
- improve wording and fix few trivial typos in comments

Committed with those last-minute changes. Thanks for the testing!

- Heikki

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2025-12-03 17:23:19 Re: SQL Property Graph Queries (SQL/PGQ)
Previous Message Nathan Bossart 2025-12-03 17:02:55 Re: [PATCH] Add enable_copy_program GUC to control COPY PROGRAM