Re: Change GUC hashtable to use simplehash?

From: "Anton A(dot) Melnikov" <a(dot)melnikov(at)postgrespro(dot)ru>
To: John Naylor <johncnaylorls(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jeff Davis <pgsql(at)j-davis(dot)com>, Ants Aasma <ants(dot)aasma(at)cybertec(dot)at>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Junwang Zhao <zhjwpku(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Gurjeet Singh <gurjeet(at)singh(dot)im>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Change GUC hashtable to use simplehash?
Date: 2025-02-14 11:40:52
Message-ID: ca93309f-7e06-451e-864c-b985e949e629@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi, Jhon!

On 14.02.2025 08:17, John Naylor wrote:
> Hi Anton, could you please test if the attached passes for you? This
> seems the simplest way.

Yes, of course. I tested this patch on the current master at 9e17ac997
in the same way and found no valgrind errors.

Moreover, with -O2 build on my PC the nsphash_lookup() has
become fully inlined with this patch and almost two time
faster - 112 asm instructions under the same conditions.
Thanks!

With the best wishes,

--
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Karlsson 2025-02-14 11:41:19 Re: PATCH: Disallow a netmask of zero unless the IP is also all zeroes
Previous Message Shlok Kyal 2025-02-14 11:27:01 Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.