| From: | Alex Guo <guo(dot)alex(dot)hengchen(at)gmail(dot)com> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: Fix DROP PROPERTY GRAPH "unsupported object class" error |
| Date: | 2026-05-06 02:38:32 |
| Message-ID: | c948abd3-7483-473c-a0e7-29c579c823fc@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 5/5/26 2:00 PM, Bertrand Drouvot wrote:
> Hi,
>
> On Thu, Apr 30, 2026 at 06:01:22PM +0530, Ashutosh Bapat wrote:
>> On Thu, Apr 30, 2026 at 4:56 PM Bertrand Drouvot
>> <bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
>>> I can see the the instability locally with en_US.UTF-8 (gt before _gt) and I
>>> can see that, for example sifaka, has en_US.UTF-8 in locales. So, modifying the
>>> impacted query a bit to add COLLATE "C" in the attached.
>>>
>> I did wonder where the instability is coming from the new query - it's
>> because now we are traversing the entire dependency tree which also
>> contains array type of reltype.
> Right.
>
>> I think we should just eliminate it
>> from the result just like we are eliminating the rule. There is slight
>> convenience in keeping the query as is - it need not change even
>> though the columns returned by the function change and it's more
>> readable. I also think that we don't need a type defined for a
>> property graph - it doesn't contain any row as well as the shape of
>> the result of GRAPH_TABLE depends upon the COLUMNS clause - so that's
>> not fixed as well. I will start a separate thread for that discussion.
> Yeah, now that 891a57c7394 is in, PFA a new version of the patch. This is just
> a mandatory rebase and the COLLATE "C" removals.
>
> Regards,
Thanks for the patch. The patch overall LGTM. There is a typo in the commit message:
"manipulated invdividually through ALTER PROPERTY GRAPH sub-commands. Hence they”
invdividually -> individually
Regards,
Alex Guo
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-05-06 03:43:39 | Re: pgindent versus struct members and typedefs |
| Previous Message | Chao Li | 2026-05-06 01:29:36 | Re: pgindent versus struct members and typedefs |