Re: Fix DROP PROPERTY GRAPH "unsupported object class" error

From: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter(at)eisentraut(dot)org>
Subject: Re: Fix DROP PROPERTY GRAPH "unsupported object class" error
Date: 2026-05-05 06:00:23
Message-ID: afmHd5vSCJtMFueS@bdtpg
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Thu, Apr 30, 2026 at 06:01:22PM +0530, Ashutosh Bapat wrote:
> On Thu, Apr 30, 2026 at 4:56 PM Bertrand Drouvot
> <bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
> >
> > I can see the the instability locally with en_US.UTF-8 (gt before _gt) and I
> > can see that, for example sifaka, has en_US.UTF-8 in locales. So, modifying the
> > impacted query a bit to add COLLATE "C" in the attached.
> >
>
> I did wonder where the instability is coming from the new query - it's
> because now we are traversing the entire dependency tree which also
> contains array type of reltype.

Right.

> I think we should just eliminate it
> from the result just like we are eliminating the rule. There is slight
> convenience in keeping the query as is - it need not change even
> though the columns returned by the function change and it's more
> readable. I also think that we don't need a type defined for a
> property graph - it doesn't contain any row as well as the shape of
> the result of GRAPH_TABLE depends upon the COLUMNS clause - so that's
> not fixed as well. I will start a separate thread for that discussion.

Yeah, now that 891a57c7394 is in, PFA a new version of the patch. This is just
a mandatory rebase and the COLLATE "C" removals.

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v6-0001-Handle-element-label-and-element-label-property-o.patch text/x-diff 31.7 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amul Sul 2026-05-05 06:37:19 Server crash: Use-after-free in AfterTriggerEndQuery()
Previous Message John Naylor 2026-05-05 05:40:13 Re: Add a greedy join search algorithm to handle large join problems