| From: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, John Naylor <john(dot)naylor(at)2ndquadrant(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WIP: Avoid creation of the free space map for small tables |
| Date: | 2019-02-26 15:25:42 |
| Message-ID: | c845a11b-7798-07e3-e5a9-a4a7131c11ff@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 26/02/2019 16:20, Alvaro Herrera wrote:
> On 2019-Feb-23, John Naylor wrote:
>
>> On Fri, Feb 22, 2019 at 3:59 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>>> The reason for not pushing much on making the test pass for
>>> nonstandard block sizes is that when I tried existing tests, there
>>> were already some failures.
>>
>> FWIW, I currently see 8 failures (attached).
>
> Hmm, not great -- even the strings test fails, which seems to try to handle
> the case explicitly. I did expect the plan shape ones to fail, but I'm
> surprised about the tablesample one.
>
The SYSTEM table sampling is basically per-page sampling so it depends
heavily on which rows are on which page.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Banck | 2019-02-26 15:35:22 | Re: Offline enabling/disabling of data checksums |
| Previous Message | Alvaro Herrera | 2019-02-26 15:20:04 | Re: WIP: Avoid creation of the free space map for small tables |