| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, ashutosh(dot)bapat(at)enterprisedb(dot)com |
| Cc: | Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com> |
| Subject: | Re: Printing LSN made easy |
| Date: | 2021-01-20 06:25:37 |
| Message-ID: | c7070d64-5edf-1206-616f-f34a57cdc1a4@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-11-27 11:40, Ashutosh Bapat wrote:
> The solution seems to be simple though. In the attached patch, I have
> added two macros
> #define LSN_FORMAT "%X/%X"
> #define LSN_FORMAT_ARG(lsn) (uint32) ((lsn) >> 32), (uint32) (lsn)
>
> which can be used instead.
It looks like we are not getting any consensus on this approach. One
reduced version I would consider is just the second part, so you'd write
something like
snprintf(lsnchar, sizeof(lsnchar), "%X/%X",
LSN_FORMAT_ARGS(lsn));
This would still reduce notational complexity quite a bit but avoid any
funny business with the format strings.
--
Peter Eisentraut
2ndQuadrant, an EDB company
https://www.2ndquadrant.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-01-20 06:29:09 | Re: Odd, intermittent failure in contrib/pageinspect |
| Previous Message | Fujii Masao | 2021-01-20 06:23:52 | Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit |