| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Misleading comment in slru.h |
| Date: | 2017-06-30 18:43:40 |
| Message-ID: | c6f518db-1446-0f48-5c6c-ebeef92f0a1c@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 6/27/17 01:43, Thomas Munro wrote:
> As mentioned in another thread[1], slru.h says:
>
> * Note: slru.c currently assumes that segment file names will be four hex
> * digits. This sets a lower bound on the segment size (64K transactions
> * for 32-bit TransactionIds).
>
> That comment is out of date: commit 638cf09e extended SLRUs to support
> 5 character names to support pg_multixact and commit 73c986ad extended
> support to 6 character SLRU file names for pg_commit_ts.
>
> Should we just remove that comment?
done
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-06-30 18:49:25 | Re: Typo in comment in xlog.c: ReadRecord |
| Previous Message | Peter Eisentraut | 2017-06-30 18:41:39 | Re: Incorrect mentions to pg_xlog in walmethods.c/h |