| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Misleading comment in slru.h |
| Date: | 2017-06-27 05:43:23 |
| Message-ID: | CAEepm=3-LAqqwgO30W6icgW2pP+N4zDFS6CTbDL-K9YBv4wx1g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi hackers,
As mentioned in another thread[1], slru.h says:
* Note: slru.c currently assumes that segment file names will be four hex
* digits. This sets a lower bound on the segment size (64K transactions
* for 32-bit TransactionIds).
That comment is out of date: commit 638cf09e extended SLRUs to support
5 character names to support pg_multixact and commit 73c986ad extended
support to 6 character SLRU file names for pg_commit_ts.
Should we just remove that comment?
--
Thomas Munro
http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| remove-misleading-comment.patch | application/octet-stream | 629 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mithun Cy | 2017-06-27 06:02:00 | Re: Proposal : For Auto-Prewarm. |
| Previous Message | Michael Paquier | 2017-06-27 05:26:31 | Incorrect mentions to pg_xlog in walmethods.c/h |