| From: | "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Jeremy Schneider <schnjere(at)amazon(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "Imseih (AWS), Sami" <simseih(at)amazon(dot)com> |
| Subject: | Re: [PATCH] Query Jumbling for CALL and SET utility statements |
| Date: | 2022-09-08 09:06:51 |
| Message-ID: | c65f1c67-bae4-9658-9206-f11e9c6f7d11@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 9/8/22 8:50 AM, Julien Rouhaud wrote:
Thanks for looking at it!
> On Thu, Sep 08, 2022 at 02:23:19PM +0900, Michael Paquier wrote:
>> On Wed, Sep 07, 2022 at 06:19:42PM -0700, Jeremy Schneider wrote:
>>> I didn't fully debug yet, but here's the backtrace on my 14.4 build with
>>> the patch
>> What happens on HEAD? That would be the target branch for a new
>> feature.
> It would be the same AFAICS. From v3:
>
> + case T_VariableSetStmt:
> + {
> + VariableSetStmt *stmt = (VariableSetStmt *) node;
> +
> + APP_JUMB_STRING(stmt->name);
> + JumbleExpr(jstate, (Node *) stmt->args);
> + }
>
> For a RESET ALL command stmt->name is NULL.
Right, please find attached v4 addressing the issue and also Sami's
comments [1].
[1]:
https://www.postgresql.org/message-id/82A35172-BEB3-4DFA-B11C-AE5E50A0F932%40amazon.com
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services:https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-JumbleQuery-on-Call-and-Set.patch | text/plain | 16.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2022-09-08 09:23:09 | pgsql: Fix perltidy breaking perlcritic |
| Previous Message | Michael Paquier | 2022-09-08 08:55:40 | Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~ |