Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~
Date: 2022-09-08 08:55:40
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Aug 30, 2022 at 01:29:24PM +1200, Thomas Munro wrote:
> This reminds me of 24c3ce8f1, which replaced a dlopen()-ish thing with
> a direct function call. Can you just call all these functions
> directly these days?

Hmm. Some tests in the CI show that attempting to call directly
MiniDumpWriteDump() causes a linking failure at compilation. Anyway,
in the same fashion, I can get some simplifications done right for
pg_ctl.c, auth.c and restricted_token.c. And I am seeing all these
functions listed in the headers of MinGW, meaning that all these
should work out of the box in this case, no?

The others are library-dependent, and I not really confident about
ldap_start_tls_sA(). So, at the end, I am finishing with the
attached, what do you think? This cuts some code, which is nice:
3 files changed, 48 insertions(+), 159 deletions(-)

Attachment Content-Type Size
win32_direct_funccalls.patch text/x-diff 12.5 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Drouvot, Bertrand 2022-09-08 09:06:51 Re: [PATCH] Query Jumbling for CALL and SET utility statements
Previous Message Anton A. Melnikov 2022-09-08 08:47:06 Re: [BUG] Logical replica crash if there was an error in a function.