Re: Subscriber resets additional columns to NULL on UPDATE

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Subscriber resets additional columns to NULL on UPDATE
Date: 2017-11-03 16:36:01
Message-ID: c62be3dc-f7e1-97fc-88bd-d6307feb2d18@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 10/26/17 05:20, Petr Jelinek wrote:
> I found bug in logical replication where extra (nullable) columns on
> subscriber will be reset to NULL value when update comes from provider.
>
> The issue is apparently that we /points finger at himself/ forgot to
> check specifically for columns that are not part of attribute map in
> slot_modify_cstrings() so the extra columns will fall through to the
> else block which sets the value to NULL.
>
> Attached patch fixes it and adds couple of tests for this scenario.
>
> This is rather serious issue so it would be good if we could get it
> fixed in 10.1.

done

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2017-11-03 17:30:42 Re: Proposal: Local indexes for partitioned table
Previous Message Peter Geoghegan 2017-11-03 16:35:39 Re: MERGE SQL Statement for PG11