| From: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Subject: | Subscriber resets additional columns to NULL on UPDATE |
| Date: | 2017-10-26 09:20:10 |
| Message-ID: | 30f3b297-d1bb-5e90-38b0-6c0b98905506@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I found bug in logical replication where extra (nullable) columns on
subscriber will be reset to NULL value when update comes from provider.
The issue is apparently that we /points finger at himself/ forgot to
check specifically for columns that are not part of attribute map in
slot_modify_cstrings() so the extra columns will fall through to the
else block which sets the value to NULL.
Attached patch fixes it and adds couple of tests for this scenario.
This is rather serious issue so it would be good if we could get it
fixed in 10.1.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Don-t-reset-additional-columns-on-subscriber-to-NULL.patch | text/x-patch | 4.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro HORIGUCHI | 2017-10-26 10:05:51 | Re: [BUGS] Bug in Physical Replication Slots (at least 9.5)? |
| Previous Message | Ashutosh Bapat | 2017-10-26 09:14:25 | Re: Re: Is anything preventing us from allowing write to foreign tables from standby? |