Re: libpq compression

From: Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>
To: David Steele <david(at)pgmasters(dot)net>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Robbie Harwood <rharwood(at)redhat(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Grigory Smolkin <g(dot)smolkin(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: libpq compression
Date: 2019-03-26 07:58:56
Message-ID: c5421f2e-918a-2e74-f91a-a951d49012c4@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 25.03.2019 13:38, David Steele wrote:
> On 3/25/19 1:04 PM, Konstantin Knizhnik wrote:
>>
>>
>> On 25.03.2019 11:06, David Steele wrote:
>>> Konstantin,
>>>
>>>
>>> This patch appears to be failing tests so I have marked it Waiting
>>> on Author.
>>>
>>> I have also removed the reviewer since no review had been done.
>>> Maybe somebody else will have a look.
>>>
>>> Regards,
>>
>> Can you please inform me which tests are failed?
>> I have done "make check-world" and there were no failed tests.
>> Actually if compression is not enabled (and it is disabled by default
>> unless explicitly requested by client), there should be no difference
>> with vanilla Postgres.
>> So it will be strange if some tests are failed without using
>> compression.
>
> Check out the cfbot report at http://commitfest.cputube.org.  Both
> platforms were failed earlier but Windows is running again now. Doubt
> that will make much difference, though.
>
> Regards,

Yet another version of the patch which should fix problems at Windows.

--
Konstantin Knizhnik
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment Content-Type Size
libpq-compression-14.patch text/x-patch 43.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-03-26 08:00:12 Re: pg_malloc0() instead of pg_malloc()+memset()
Previous Message Tsunakawa, Takayuki 2019-03-26 07:56:04 RE: Re: reloption to prevent VACUUM from truncating empty pages at the end of relation