| From: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Copy function for logical replication slots |
| Date: | 2019-04-05 21:53:22 |
| Message-ID: | c4fad651-ecce-667c-596e-29a4d1dcd3ba@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 05/04/2019 23:16, Alvaro Herrera wrote:
> Pushed this.
>
Thanks!
> The mechanism of creating a new slot from the source, then later
> advancing the LSN of the new slot using the updated values from the
> source slot, seems quite clever. I reworded the comment that explained
> how it is supposed to work; please double-check to ensure I got it
> right.
>
Besides the "We regards it" typo it looks fine to me.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2019-04-05 21:57:03 | Re: New vacuum option to do only freezing |
| Previous Message | Masahiko Sawada | 2019-04-05 21:47:32 | Re: [HACKERS] Block level parallel vacuum |