Re: Re: Copy function for logical replication slots

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: David Steele <david(at)pgmasters(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: Copy function for logical replication slots
Date: 2019-04-05 21:16:11
Message-ID: 20190405211610.GA24735@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Pushed this.

The mechanism of creating a new slot from the source, then later
advancing the LSN of the new slot using the updated values from the
source slot, seems quite clever. I reworded the comment that explained
how it is supposed to work; please double-check to ensure I got it
right.

I renamed the opr_sanity-induced wrappers. I see no reason to get
very precise about what's what ... these functions are all identical.

Thanks everyone!

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jonathan S. Katz 2019-04-05 21:19:28 Re: initdb recommendations
Previous Message Peter Eisentraut 2019-04-05 20:58:11 Re: initdb recommendations