From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
---|---|
To: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
Cc: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Florents Tselai <florents(dot)tselai(at)gmail(dot)com> |
Subject: | Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close |
Date: | 2025-06-22 13:47:27 |
Message-ID: | c3d1bd20-5823-44c6-84e0-9a964f703fd9@eisentraut.org |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 20.06.25 16:41, David G. Johnston wrote:
> I sense there could be some confusion whether such draft patches
> should go into the regular commit fest or the draft commit fest, and
> then also when they should move between them.
>
> Draft CF patches with “Needs Review” are looking for feedback from
> others or otherwise aid in development for a patch that isn’t ready to
> be committed even if said review turns up nothing or is otherwise fully
> resolved. Patches in Drafts are never marked Ready to Commit, they get
> moved to Open first.
>
> It will be nice if people spend time providing reviews/feedback to
> patches in Drafts when requested.
>
> It’s purely the author’s judgement on the readiness of the patch,
> whether absent our policy they would mark it ready to commit or not. If
> they believe it is it should be moved to open, if no, it should remain
> in drafts. This is mostly like what happens today but with a clear
> delineation between reviews to help and reviews to approve commit-ability.
>
> Otherwise, it’s a place where author patches can sit without having to
> be bumped to the next cf every other month and where an author patch can
> be ignored by everyone else not authoring it.
I don't know about this. This could become an ongoing source of
confusion, without any clear benefit. Either the draft and the "real"
commitfest are going to be indistinguishable, because they are just two
places to look for stuff to review in various phases of maturity. Or
the draft commitfest is just not going to get any attention, which will
be annoying for those who put things there hoping to get attention.
From | Date | Subject | |
---|---|---|---|
Next Message | David G. Johnston | 2025-06-22 14:21:36 | Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close |
Previous Message | Peter Eisentraut | 2025-06-22 13:38:30 | Re: pg_recvlogical cannot create slots with failover=true |