Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Florents Tselai <florents(dot)tselai(at)gmail(dot)com>
Subject: Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close
Date: 2025-06-20 14:41:42
Message-ID: CAKFQuwbYNSeAz=iwWReVXFaTnOeMq4xTp_xBoAEF43tGSzVU1Q@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Friday, June 20, 2025, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:

> On 16.06.25 14:47, Jelte Fennema-Nio wrote:
>
>> # Draft CF
>>
>> There's now an additional Draft CF. People can move patches there as a
>> way of not forgetting about them. CFBot will rerun these patches less
>> frequently (exact behaviour TBD). Draft CFs are never "In Progress"
>> and are open until the final CF of the release cycle becomes "In
>> Progress". So PG19-Drafts will close on February 28th 2026, and at the
>> same moment PG20-Drafts will be opened.
>>
>
> Can we clarify the expectations around this?
>
> In some early discussions, I had heard this being talked about as a
> "parking lot". You can put patches there so that they get CI runs, but no
> one else is really expected to pay attention to them. Makes sense.
>
> But many patches that are routinely submitted to normal commit fests are
> really drafts, in that they are in an early phase of development but still
> need feedback.
>
> I sense there could be some confusion whether such draft patches should go
> into the regular commit fest or the draft commit fest, and then also when
> they should move between them.
>

Draft CF patches with “Needs Review” are looking for feedback from others
or otherwise aid in development for a patch that isn’t ready to be
committed even if said review turns up nothing or is otherwise fully
resolved. Patches in Drafts are never marked Ready to Commit, they get
moved to Open first.

It will be nice if people spend time providing reviews/feedback to patches
in Drafts when requested.

It’s purely the author’s judgement on the readiness of the patch, whether
absent our policy they would mark it ready to commit or not. If they
believe it is it should be moved to open, if no, it should remain in
drafts. This is mostly like what happens today but with a clear
delineation between reviews to help and reviews to approve commit-ability.

Otherwise, it’s a place where author patches can sit without having to be
bumped to the next cf every other month and where an author patch can be
ignored by everyone else not authoring it.

David J.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Melanie Plageman 2025-06-20 14:45:29 Re: Vacuum ERRORs out considering freezing dead tuples from before OldestXmin
Previous Message Tom Lane 2025-06-20 14:40:30 Re: Prevent numeric literals from having non-numeric trailing characters (Peter Eisentraut)