| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: astreamer fixes |
| Date: | 2026-03-29 13:16:16 |
| Message-ID: | c2fb2a5b-d7fc-4d25-b6f7-db6ab51c5e1b@dunslane.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2026-03-28 Sa 3:46 PM, Tom Lane wrote:
> Andrew Dunstan<andrew(at)dunslane(dot)net> writes:
>> On 2026-03-28 Sa 1:48 PM, Tom Lane wrote:
>>> but I don't like the other bit
>>>
>>> + /* If we've hit the end of the compressed stream, stop. */
>>> + if (res == Z_STREAM_END)
>>> + break;
>>>
>>> Paying attention to the amount of data consumed seems just as
>>> good and takes less code.
>> So IIUC, you agree with the patch except for this last piece, on which I
>> agree with your reasoning.
> Right, I would leave out the above-quoted hunk but the rest of it
> looks good.
>
>
Thanks. pushed.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2026-03-29 13:33:10 | Re: pg_waldump: support decoding of WAL inside tarfile |
| Previous Message | Alexander Korotkov | 2026-03-29 12:34:06 | Re: Exit walsender before confirming remote flush in logical replication |