Re: astreamer fixes

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: astreamer fixes
Date: 2026-03-28 19:46:01
Message-ID: 1608739.1774727161@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 2026-03-28 Sa 1:48 PM, Tom Lane wrote:
>> but I don't like the other bit
>>
>> + /* If we've hit the end of the compressed stream, stop. */
>> + if (res == Z_STREAM_END)
>> + break;
>>
>> Paying attention to the amount of data consumed seems just as
>> good and takes less code.

> So IIUC, you agree with the patch except for this last piece, on which I
> agree with your reasoning.

Right, I would leave out the above-quoted hunk but the rest of it
looks good.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2026-03-28 21:36:06 Re: pg_waldump: support decoding of WAL inside tarfile
Previous Message Lukas Fittl 2026-03-28 19:38:04 Re: pg_buffercache: Add per-relation summary stats