Re: Logical replication: stuck spinlock at ReplicationSlotRelease

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Logical replication: stuck spinlock at ReplicationSlotRelease
Date: 2017-06-24 00:58:02
Message-ID: c252108d-5652-b5fd-4ec2-7dbfb92866bb@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 6/23/17 16:15, Andres Freund wrote:
> On 2017-06-23 13:26:58 -0400, Alvaro Herrera wrote:
>> Hmm, so for instance in LogicalIncreaseRestartDecodingForSlot() we have
>> some elog(DEBUG1) calls with the slot spinlock held. That's probably
>> uncool.
>
> It definitely is not cool, rather daft even (it's probably me who wrote
> that). No idea why I've done it like that, makes no sense.

Do you want to take a look at move those elog calls around a bit? That
should do it.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2017-06-24 01:41:14 Re: Get stuck when dropping a subscription during synchronizing table
Previous Message Stephen Frost 2017-06-23 23:43:35 Re: pg_terminate_backend can terminate background workers and autovacuum launchers