Re: Logical replication: stuck spinlock at ReplicationSlotRelease

From: Andres Freund <andres(at)anarazel(dot)de>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>, 'Peter Eisentraut *EXTERN*' <peter(dot)eisentraut(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Logical replication: stuck spinlock at ReplicationSlotRelease
Date: 2017-06-23 20:15:09
Message-ID: 20170623201509.35ofoplznwmb5tcf@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2017-06-23 13:26:58 -0400, Alvaro Herrera wrote:
> Hmm, so for instance in LogicalIncreaseRestartDecodingForSlot() we have
> some elog(DEBUG1) calls with the slot spinlock held. That's probably
> uncool.

It definitely is not cool, rather daft even (it's probably me who wrote
that). No idea why I've done it like that, makes no sense.

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-06-23 20:38:42 Re: initdb initalization failure for collation "ja_JP"
Previous Message Peter Eisentraut 2017-06-23 20:10:35 Re: Logical replication: stuck spinlock at ReplicationSlotRelease