Re: check error messages in SSL tests

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: check error messages in SSL tests
Date: 2018-03-06 19:54:16
Message-ID: c0a6958b-1dd6-11ad-7953-6d34341b2e33@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2/24/18 10:12, Peter Eisentraut wrote:
> On 2/24/18 07:37, Michael Paquier wrote:
>> On Fri, Feb 23, 2018 at 01:57:44PM -0500, Peter Eisentraut wrote:
>>> Oh. I actually had that file as 0600 in my checked-out tree, probably
>>> from earlier experiments. Fixed that. And I also changed it to make
>>> another temp file that is explicitly 0644, because we can't rely on that
>>> being the default either.
>>
>> Thanks for fixing the first one. I also like the second change. This
>> patch looks fine to me.
>
> committed

This contains a slight problem: The tests contain two different
branches, depending on whether tls-server-end-point is supported. But
these branches run a different number of tests, so the test count of the
top of the test file might be wrong. Here is a patch that restructures
this to count the tests more dynamically.

Thoughts?

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
0001-Fix-test-counting-in-SSL-tests.patch text/plain 1.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2018-03-06 19:56:41 Re: [HACKERS] [Patch] Log SSL certificate verification errors
Previous Message Peter Eisentraut 2018-03-06 19:44:26 Re: [COMMITTERS] pgsql: Add much-more-extensive TAP tests for pgbench.