| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: check error messages in SSL tests |
| Date: | 2018-03-07 01:38:44 |
| Message-ID: | 20180307013844.GB1744@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 06, 2018 at 02:54:16PM -0500, Peter Eisentraut wrote:
> This contains a slight problem: The tests contain two different
> branches, depending on whether tls-server-end-point is supported. But
> these branches run a different number of tests, so the test count of the
> top of the test file might be wrong. Here is a patch that restructures
> this to count the tests more dynamically.
Not sure how I missed that. The error is obvious as command_ok triggers
one test and command_fails_like does two of them. Test::More also
documents what you are using here, so the patch looks fine to me.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-03-07 01:46:24 | Re: BUG #14999: pg_rewind corrupts control file global/pg_control |
| Previous Message | David Rowley | 2018-03-07 01:34:26 | Re: [HACKERS] path toward faster partition pruning |