Re: Collation versioning

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Julien Rouhaud <rjuju123(at)gmail(dot)com>, Christoph Berg <myon(at)debian(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Douglas Doole <dougdoole(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Collation versioning
Date: 2020-03-18 20:29:55
Message-ID: c0514679-2a96-39ca-c0b7-99f61f3331cf@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-03-17 18:43, Julien Rouhaud wrote:
> On Tue, Mar 17, 2020 at 05:31:47PM +0100, Christoph Berg wrote:
>> Re: Peter Eisentraut 2020-03-17<fd8d4475-85ad-506f-2dda-f4d6e66785bc(at)2ndquadrant(dot)com>
>>> Did we discuss the regcollation type? In the current patch set, it's only
>>> used in two places in a new regression test, where it can easily be replaced
>>> by a join. Do we need it?
>
> I originally wrote it for a previous version of the patchset, to shorten the
> pg_dump query, but that went out when I replaced the DDL command with native
> functions instead. It didn't seem to hurt to keep it, so I relied on it in the
> regression tests.

OK, I have committed the regcollation patch, and some surrounding
cleanup of the reg* types documentation.

Note that your patch updated the pg_upgrade documentation to say that
tables with regcollation columns cannot be upgraded but didn't actually
patch the pg_upgrade code to make that happen.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2020-03-18 21:02:13 Re: BEFORE ROW triggers for partitioned tables
Previous Message Andres Freund 2020-03-18 20:25:30 Re: potential stuck lock in SaveSlotToPath()