Re: Support custom socket directory in pg_upgrade

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Support custom socket directory in pg_upgrade
Date: 2018-11-07 07:23:22
Message-ID: bfed6767-a25c-c7f1-79bf-f2517c6a824a@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 09/10/2018 15:09, Daniel Gustafsson wrote:
> Having hit the maximum socketdir length error a number of times in pg_upgrade,
> especially when running tests in a deep directory hierarchy, I figured it was
> time to see if anyone else has had the same problem? The attached patch is
> what I run with locally to avoid the issue, it adds a --socketdir=PATH option
> to pg_upgrade which overrides the default use of CWD. Is that something that
> could be considered?

Why not always create a temporary directory and put it there. Then we
don't need an option. It's not like the current directory is a
particularly good choice anyway.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2018-11-07 07:24:08 Re: Reduce maintenance burden of alternative output files with \if \quit
Previous Message Peter Eisentraut 2018-11-07 07:21:09 Re: Reduce maintenance burden of alternative output files with \if \quit