| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Cc: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Explicitly enable meson features in CI |
| Date: | 2025-07-28 13:27:58 |
| Message-ID: | bed85954-588d-4b94-b4c9-e9387c9c3119@dunslane.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025-07-28 Mo 8:08 AM, Daniel Gustafsson wrote:
>> On 17 Jul 2025, at 10:33, Nazir Bilal Yavuz<byavuz81(at)gmail(dot)com> wrote:
>> On Wed, 16 Jul 2025 at 18:24, Jacob Champion<jacob(dot)champion(at)enterprisedb(dot)com> wrote:
>>> Is there anything else in particular you'd like review on? (I've
>>> marked this patchset RfC.)
> Reading over the v6 version posted upthread, I agree with the patch being
> ready. Are you taking care of it Jacob?
>
> - # disable -Dnls as the number of files it creates cause a noticable slowdown
> + # -Dnls need to be disabled as the number of files it creates cause a noticable slowdown
>
> I think this should be s/noticable/noticeable/ (which is a nitpick a commmitter
> can deal with, no need for a new version IMO).
At the same time they should do:
s/need/needs/
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrei Lepikhov | 2025-07-28 13:29:06 | Re: Pushing down a subquery relation's ppi_clauses, and more ... |
| Previous Message | Daniel Gustafsson | 2025-07-28 13:06:23 | Re: PG 18 beta1 release notes misses mention of pg_noreturn |