| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Cc: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Explicitly enable meson features in CI |
| Date: | 2025-07-28 12:08:15 |
| Message-ID: | A4592429-98D2-4B92-856D-F2A9D5129110@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 17 Jul 2025, at 10:33, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
> On Wed, 16 Jul 2025 at 18:24, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> wrote:
>> Is there anything else in particular you'd like review on? (I've
>> marked this patchset RfC.)
Reading over the v6 version posted upthread, I agree with the patch being
ready. Are you taking care of it Jacob?
- # disable -Dnls as the number of files it creates cause a noticable slowdown
+ # -Dnls need to be disabled as the number of files it creates cause a noticable slowdown
I think this should be s/noticable/noticeable/ (which is a nitpick a commmitter
can deal with, no need for a new version IMO).
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ajin Cherian | 2025-07-28 12:21:13 | Re: 024_add_drop_pub.pl might fail due to deadlock |
| Previous Message | Ajin Cherian | 2025-07-28 12:06:52 | Re: 024_add_drop_pub.pl might fail due to deadlock |